-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GHA): Pin azure/setup-helm #11493
Conversation
DryRun Security SummaryThe pull request modifies the DefectDojo Helm chart release workflow by implementing secure practices such as dependency version pinning and structured release steps, while maintaining the integrity of the release process through separate branch management for the Helm repository index. Expand for full summarySummary: The changes in this pull request are focused on the release process of the DefectDojo Helm chart and do not introduce any obvious security concerns. The GitHub Actions workflow responsible for the Helm chart release follows best practices, such as pinning dependencies to specific versions and updating the Helm repository index in a separate branch. These practices help maintain the security and reliability of the release process. The key changes include setting up the Helm CLI with a specific, known version, configuring the Bitnami Helm repository, pinning the Docker image version to the release number, packaging the Helm chart, creating a new GitHub release, and updating the Helm repository index. All of these steps are standard parts of the release process and do not raise any immediate security concerns. Files Changed:
Code AnalysisWe ran |
I dropped The pin is not missing that often. Keeping another config would just increase overhead. |
Co-authored-by: Cody Maffucci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Add
pinact
which is able to detect unpinned GHA